Repository navigation
Document commit-trigger branch regexes and fork-safe Copr builds - #1182
Open
Nitjsefnie wants to merge 2 commits into
Open
Nitjsefnie wants to merge 2 commits into
Nitjsefnie wants to merge 2 commits into
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com> Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com> Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
Contributor
Author
|
Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that the
branchoption of atrigger: commitPackit job accepts a Python regular expression — matching usesre.match, anchored at the start of the branch name (^unnecessary) and not required to consume the whole name, sobranch: mainalso matchesmain-fixandmain/probe— and add a worked example for getting Copr builds from a fork when the upstream config pins an explicit Coprowner/project: a second job withoutowner/project(Packit's default project naming works from a fork) with a distinctidentifier, restricted to non-default branches via a branch regex.Related Issues and Pull Requests
Fixes #664
Fixes #631
Changes
docs/configuration/upstream/copr_build.md: thebranchbullet now documents regex support with the exact matching semantics (start-anchoredre.match, partial match allowed), a plain-name example and its exact-name variant (main$), and a worked "every branch except the default" pattern^(?!main$).*.docs/configuration/examples.md: new "Running Copr builds from a fork without changing the upstream project" example — keep the upstream job with explicitowner/project, add a second job without them (default Copr naming), give both jobs distinctidentifiervalues, and split them with complementarymain$/^(?!main$).*branch filters; notes the regex-metacharacter escaping caveat for other default branch names and the remaining permission limitation for pushes to the fork'smain.Testing
Docs-only change; no runtime behavior changed. The example YAML parses (
yaml.safe_load), and the documented matching semantics were verified against packit-service's matching source (packit_service/worker/helpers/build/build_helper.pyusesre.match) and probed with Python. Fork CI green on the branch head a07a67f:osc-manual.ymlrun 39836032954 on the fork, 1 job green, provenance echo naming that SHA.Footer
Generated by GLM-5.3-Flash (brief, orchestration), GPT-6.1 Sol (implementation), GPT-6 Astra (review)