Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 46.91% 43.40% -3.51%
==========================================
Files 20 20
Lines 2498 2534 +36
==========================================
- Hits 1172 1100 -72
- Misses 1326 1434 +108 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f6fc483 to
016e0b0
Compare
|
@blegat Can you do the same modification for the acyclic bicoloring? |
|
@blegat You also forgot to update the method |
|
@blegat "For a tree index `1 <= k <= nt`, `is_star[k]` indicates whether the `k`th tree is a star."I also want to fix a comment in the # Note: tree_edge_indices contains the positions of the first and last edges.
# Each tree has one more vertex than edges, so the k-1 previous trees shift
# the vertex positions by k-1 with respect to the edge positions. |
Reuse the existing CSC write logic for one-edge trees, whose value can be read directly from the compressed matrix without substitution. Move that logic into a helper shared by the one-edge case and the general substitution path.
Small recovery benchmark for 250 dense 20×20 blocks, run with SMC before and after this change:
Measured medians for the same block pattern (5,000 variables); full Hessian evaluation was benchmarked separately through MOI:
On Julia 1.13.1 with Intel i7-12700K.