Repository navigation
GPU Metal: accept the registration of host memory - #16067
Merged
Merged
Conversation
The GPU reconstruction workflow registers its shared-memory segments for the GPU, and the Metal backend fell back to the device base, which fails for every GPU backend that does not implement it: the full system test's WITHGPU stage stopped with "Error registering memory for GPU". Metal memory is shared with the host, and GPUMemCpy copies from memory outside the Metal buffers on the host, so there is nothing to pin: accept the registration as the CPU backend does.
Member
Author
|
Metal only, tested locally. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU reconstruction workflow registers its shared-memory segments
for the GPU, and the Metal backend fell back to the device base, which
fails for every GPU backend that does not implement it: the full
system test's WITHGPU stage stopped with "Error registering memory
for GPU". Metal memory is shared with the host, and GPUMemCpy copies
from memory outside the Metal buffers on the host, so there is nothing
to pin: accept the registration as the CPU backend does.